Re: [Xen-devel] [PATCH] x86/altp2m: Add a subop for obtaining the mem access of a page

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.07.18 at 15:20, <apop@xxxxxxxxxxxxxxx> wrote:
> On Wed, Jul 04, 2018 at 03:20:45PM +0300, Adrian POP wrote:
>> On Fri, Jun 29, 2018 at 09:38:58AM -0600, Jan Beulich wrote:
>> > > --- a/xen/arch/x86/mm/mem_access.c
>> > > +++ b/xen/arch/x86/mm/mem_access.c
>> > > @@ -32,17 +32,10 @@
>> > >  
>> > >  #include "mm-locks.h"
>> > >  
>> > > -/*
>> > > - * Get access type for a gfn.
>> > > - * If gfn == INVALID_GFN, gets the default access type.
>> > > - */
>> > > -static int _p2m_get_mem_access(struct p2m_domain *p2m, gfn_t gfn,
>> > > -                               xenmem_access_t *access)
>> > > +static int p2m_access_to_xenmem_access(struct p2m_domain *p2m,
>> > 
>> > This is not even p2m code - why the p2m_ prefix?
>> 
>> There's indeed no reason for this to have the p2m_ prefix.  Will remove
>> it.
> 
> Oh I remember now.  The p2m_ prefix was added there because the helper
> function converts a p2m_access_t to a xenmem_access_t, so
> p2m_access_to_xenmem_access().  Took the naming from the complementary
> function, xenmem_access_to_p2m_access().  I could add a comment to
> clarify this.

Oh, of course - I simply wasn't paying attention to this aspect, sorry.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel