Re: [Xen-devel] [PATCH v10 02/11] x86/hvm: Introduce hvm_save_tsc_adjust_one() func

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Alexandru Isaila [mailto:aisaila@xxxxxxxxxxxxxxx]
> Sent: 04 July 2018 14:32
> To: xen-devel@xxxxxxxxxxxxx
> Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxx>; Wei Liu <wei.liu2@xxxxxxxxxx>;
> jbeulich@xxxxxxxx; Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; Paul
> Durrant <Paul.Durrant@xxxxxxxxxx>; Alexandru Isaila
> <aisaila@xxxxxxxxxxxxxxx>
> Subject: [PATCH v10 02/11] x86/hvm: Introduce hvm_save_tsc_adjust_one()
> func
> 
> This is used to save data from a single instance.
> 
> Signed-off-by: Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>

Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> 
> ---
> Changes since V9:
>      - Change return of the save_one func to return hvm_save_entry.
> ---
>  xen/arch/x86/hvm/hvm.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index 93092d2..c47d162 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -740,20 +740,26 @@ void hvm_domain_destroy(struct domain *d)
>      destroy_vpci_mmcfg(d);
>  }
> 
> +static int hvm_save_tsc_adjust_one(struct vcpu *v,
> hvm_domain_context_t *h)
> + {
> +    struct hvm_tsc_adjust ctxt;
> +
> +    ctxt.tsc_adjust = v->arch.hvm_vcpu.msr_tsc_adjust;
> +
> +    return hvm_save_entry(TSC_ADJUST, v->vcpu_id, h, &ctxt);
> + }
> +
>  static int hvm_save_tsc_adjust(struct domain *d, hvm_domain_context_t
> *h)
>  {
>      struct vcpu *v;
> -    struct hvm_tsc_adjust ctxt;
>      int err = 0;
> 
>      for_each_vcpu ( d, v )
>      {
> -        ctxt.tsc_adjust = v->arch.hvm_vcpu.msr_tsc_adjust;
> -        err = hvm_save_entry(TSC_ADJUST, v->vcpu_id, h, &ctxt);
> +        err = hvm_save_tsc_adjust_one(v, h);
>          if ( err )
>              break;
>      }
> -
>      return err;
>  }
> 
> --
> 2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel