Re: [Xen-devel] [PATCH v3 3/6] libxc: allow HVM guest to have modules

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jul 05, 2018 at 11:42:34AM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH v3 3/6] libxc: allow HVM guest to have modules"):
> > On Thu, Jul 05, 2018 at 11:29:41AM +0100, Ian Jackson wrote:
> > > AIUI you mean something more like
> > > 
> > >   Now the code needs to handle virt_base being UNSET_ADDR, which it is
> > >   for HVM guests.  In that case seg.vstart is interpreted by ???
> > >   as an ??? offset from zero ???
> > 
> > Now the code needs to handle virt_base being UNSET_ADDR, which it is for
> > HVM guest. In case PVH and PV, virt_base is set by the respective loader
> > by parsing the binary.
> 
> That doesn't explain how the necessary value of seg.vstart can be
> calculated without needing to know the not-yet-calculated value of
> virt_base.

virt_base should already be calculated at this point. It is either set
or not. There is possibility for setting 0 at some point but it doesn't
change how we interpret UNSET_ADDR.

Wei.

> 
> Thanks,
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel