Re: [Xen-devel] [PATCH v2 1/2] x86/mem_access: Add a helper function for memaccess conversion

[Adrian Pop <apop@xxxxxxxxxxxxxxx>]

On Thu, Jul 05, 2018 at 10:53:22AM -0600, Tamas K Lengyel wrote:
> On Thu, Jul 5, 2018 at 4:44 AM Adrian Pop <apop@xxxxxxxxxxxxxxx> wrote:
> > @@ -72,11 +83,7 @@ static int _p2m_get_mem_access(struct p2m_domain *p2m, 
> > gfn_t gfn,
> >      if ( mfn_eq(mfn, INVALID_MFN) )
> >          return -ESRCH;
> >
> > -    if ( (unsigned int)a >= ARRAY_SIZE(memaccess) )
> > -        return -ERANGE;
> > -
> > -    *access =  memaccess[a];
> > -    return 0;
> > +    return access_to_xenmem_access(p2m, a, access);
> 
> Shouldn't this be p2m_access_to_xenmem_access? Did you compile check
> this patch before sending?

Oh, that's right!  It seems I've mistakenly used an intermediary version
of the patch when testing unfortunately.

Thank you!

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel