Re: [Xen-devel] [PATCH v2 02/13] libx86: Introduce libx86/cpuid.h

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.07.18 at 22:03, <andrew.cooper3@xxxxxxxxxx> wrote:
> Begin to untangle the header dependency tangle by moving definition of
> struct cpuid_leaf out of x86_emulate.h into the new cpuid.h.
> 
> Additionally, plumb the header through to libxc.  This is technically a
> redundant include at this point, but it helps build-test the later changes,
> and will be used eventually.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Sergey Dyasli <sergey.dyasli@xxxxxxxxxx>
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> 
> Note concerning the positioning of libx86.  It turns out after trying to move
> it elsewhere that the movement is prohibitive because of the way Xen headers
> are included by the tools.

If there's really something preventing it to be placed better, then I'm
certainly willing to give my ack here, but I'd like to have a more clear
understanding of what issue(s) you are talking about above.

> For now, this is consistent with the other libs, and we can move it in the
> future after some hygene has been applied to the build system.

After all even better to avoid code churn resulting from such extra
movement.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel