[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 01/13] x86/msr: Drop stale comment for vcpu_msrs.spec_ctrl

On Fri, Jul 13, 2018 at 09:03:02PM +0100, Andrew Cooper wrote:
> More than the bottom two bits are now defined, and the MSR policy work has
> shown that using non-architectural representations turns out to be problematic
> for more than just asm code.  As the architectural representation is the
> expected default, we don't need to justify why we are using it.

If that's indeed the architectural representation shouldn't you use a
uint64_t instead?

> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.