[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 04/31] libxl_json: fix build with DEBUG_ANSWER

On Wed, Jun 27, 2018 at 03:22:56PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH v3 04/31] libxl_json: fix build with 
> > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Although,
> >          yajl_gen_get_buf((yajl_ctx)->g, &buf, &len); \
> > -        LIBXL__LOG(libxl__gc_owner((yajl_ctx)->gc), LIBXL__LOG_DEBUG,
> > -              "response:\n", buf); \
> > +        LIBXL__LOG(libxl__gc_owner((yajl_ctx)->gc), XTL_DEBUG, \
> > +              "response: %s\n", buf); \
> I'm not sure why you changed LIBXL__LOG_DEBUG to XTL_DEBUG.  It would

I'm not sure either.

> be nice to mention it in the commit message.  Personally I would
> prefer it because (i) it's shorter (ii) we're not likely to want to
> decouple the libxl log levels from the XTL ones (iii) if we do, in the
> future, it will be an easy search-and-replace.

Ok, I'll keep the change, and add to the commit message:
  Also replace LIBXL__LOG_DEBUG by XTL_DEBUG, because it's shorter and
  more often used in libxl.

Anthony PERARD

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.