Re: [Xen-devel] [PATCH v2 20/21] xen: support console_switching between Dom0 and DomUs on ARM

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 17 Jul 2018, Jan Beulich wrote:
> >>> On 16.07.18 at 23:55, <sstabellini@xxxxxxxxxx> wrote:
> > On Mon, 16 Jul 2018, Jan Beulich wrote:
> >> >>> On 07.07.18 at 01:12, <sstabellini@xxxxxxxxxx> wrote:
> >> > +            serial_rx_ring[SERIAL_RX_MASK(serial_rx_prod++)] = c;
> >> > +    }
> >> > +#ifdef CONFIG_ARM
> >> 
> >> CONFIG_HAS_PL011 ?
> > 
> > I had already spotted this problem. I turned it into:
> > 
> >   #if defined(CONFIG_ARM) && defined(CONFIG_SBSA_VUART_CONSOLE)
> > 
> > It's CONFIG_SBSA_VUART_CONSOLE rather than CONFIG_HAS_PL011 because this
> > has to do with the virtual pl011 implementation rather than the physical
> > driver in Xen.
> 
> I see. But why still the CONFIG_ARM?

Good point, I'll remove it.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel