[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 1/2] x86: report use of PCID together with reporting XPTI status

>>> On 18.07.18 at 10:46, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 18/07/2018 09:33, Jan Beulich wrote:
>> --- a/xen/include/asm-x86/spec_ctrl.h
>> +++ b/xen/include/asm-x86/spec_ctrl.h
>> @@ -38,6 +38,8 @@ extern uint8_t opt_xpti;
>>  #define OPT_XPTI_DOM0  0x01
>>  #define OPT_XPTI_DOMU  0x02
>> +bool xpti_pcid_enabled(void);
> This still should be inside an CONFIG_PV to avoid scenarios which will
> compile correctly but fail to link.  It should live in pv/domain.h at
> which point everything should be fine.

It was intentional that I didn't move the declaration: Whether the build
fails at the compile or link stage is irrelevant imo. All we need is that it
fail at all. I would have moved it if its current placement wasn't again
very intentional, next to the other XPTI pieces.

> With that, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Please clarify whether you can live with the above.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.