Re: [Xen-devel] [PATCH] shim: Fix generation of compat/callback.i: allow redef of OBJECT vars

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.07.18 at 01:33, <christopher.w.clark@xxxxxxxxx> wrote:
> When cross-compiling for x86 with gcc 8.1, the generation of
> compat/callback.i fails due to the redefinition of __OBJECT_FILE__ and
> __OBJECT_LABEL__ variables on the compiler command line during the shim
> build:
> 
> | <command-line>: error: "__OBJECT_FILE__" redefined [-Werror]
> | <command-line>: note: this is the location of the previous definition
> | <command-line>: error: "__OBJECT_LABEL__" redefined [-Werror]
> | <command-line>: note: this is the location of the previous definition
> | cc1: all warnings being treated as errors
> | Makefile:69: recipe for target 'compat/callback.i' failed

First of all, as to the title - is this really just affecting callback.i? If so,
why? If not, the title should be generalized.

> __OBJECT_LABEL__ is already unset-before-set in one location where it is
> defined in xen/arch/x86/Rules.mk ; this patch applies the same to the
> other define site in the same file.
> 
> __OBJECT_FILE__ is handled similarly: an undefine statement is added
> before its definition in xen/Rules.mk

Now what you fail to explain is what these double definitions result
from. Understanding that my suggest alternative approaches to
addressing the issue. For example there may me undue propagation
of CFLAGS at some layer.

> Signed-off-by: Christopher Clark <christopher.clark6@xxxxxxxxxxxxxx>
> ---
> Please use my gmail address for any correspondence to me.

I think it is generally considered bad practice to have From: and S-o-b
differ.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel