Re: [Xen-devel] [PATCH] lzma: fix hypervisor build

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Jul 20, 2018 at 11:17:18AM +0200, Juergen Gross wrote:
> On 20/07/18 11:00, Wei Liu wrote:
> > On Fri, Jul 20, 2018 at 10:32:42AM +0200, Roger Pau Monne wrote:
> >> Remove local definition of MIN and instead include the kernel.h header
> >> for the hypervisor build. Fixes the following error on the tools build:
> >>
> >> In file included from xc_dom_decompress_unsafe_lzma.c:8:0:
> >> ../../xen/common/unlzma.c:33:0: error: "MIN" redefined [-Werror]
> >>  #define MIN(a, b) (((a) < (b)) ? (a) : (b))
> >>  ^
> >> In file included from xc_private.h:43:0,
> >>                  from xg_private.h:29,
> >>                  from xc_dom_decompress_unsafe_lzma.c:5:
> >> /home/osstest/build.125458.build-amd64/xen/stubdom/libxc-x86_64/../../tools/include/xen-tools/libs.h:21:0:
> >>  note: this is the location of the previous definition
> >>  #define MIN(x, y) ((x) < (y) ? (x) : (y))
> >>  ^
> >>
> >> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > 
> > Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > 
> > Strangely I never saw this during my build.
> 
> What did your ./configure run say about lzma support?

It appears that it got broken yesterday-ish so I never had a chance to
see it. :-)

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel