[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH net-next] xen-netfront: fix queue name setting

On 07/20/2018 05:33 PM, Vitaly Kuznetsov wrote:
Commit f599c64fdf7d ("xen-netfront: Fix race between device setup and
open") changed the initialization order: xennet_create_queues() now
happens before we do register_netdev() so using netdev->name in
xennet_init_queue() is incorrect, we end up with the following in

  60:        139          0   xen-dyn    -event     eth%d-q0-tx
  61:        265          0   xen-dyn    -event     eth%d-q0-rx
  62:        234          0   xen-dyn    -event     eth%d-q1-tx
  63:          1          0   xen-dyn    -event     eth%d-q1-rx

and this looks ugly. Actually, using early netdev name (even when it's
already set) is also not ideal: nowadays we tend to rename eth devices
and queue name may end up not corresponding to the netdev name.

Use nodename from xenbus device for queue naming: this can't change in VM's
lifetime. Now /proc/interrupts looks like

  62:        202          0   xen-dyn    -event     device/vif/0-q0-tx
  63:        317          0   xen-dyn    -event     device/vif/0-q0-rx
  64:        262          0   xen-dyn    -event     device/vif/0-q1-tx
  65:         17          0   xen-dyn    -event     device/vif/0-q1-rx

Fixes: f599c64fdf7d ("xen-netfront: Fix race between device setup and open")
Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>

Reviewed-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.