[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] firmware/shim : filter output files during Xen tree setup

On Mon, Jul 23, 2018 at 2:26 AM, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
On 23/07/18 10:09, Roger Pau Monné wrote:
> On Fri, Jul 20, 2018 at 02:15:05PM -0700, Christopher Clark wrote:
>> Exclude named output files from the Xen tree setup.
>> The linkfarm.stamp content will differ between top level "make"
>> and "make install" invocations, due to the introduction of these
>> output files that are produced during the "make" build.
>> Filter these out to prevent an unnecessary rebuild of the shim during
>> "make install".
>> Signed-off-by: Christopher Clark <christopher.clark6@baesystems.com>
>> ---
>>  tools/firmware/xen-dir/Makefile | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>> diff --git a/tools/firmware/xen-dir/Makefile b/tools/firmware/xen-dir/Makefile
>> index 84648c3..e490dca 100644
>> --- a/tools/firmware/xen-dir/Makefile
>> +++ b/tools/firmware/xen-dir/Makefile
>> @@ -11,6 +11,9 @@ D=xen-root
>>  LINK_DIRS=config xen
>>  LINK_FILES=Config.mk
>> +# Files to exclude from the link farm
>> +EXCLUDE_FILES=xen xen.gz xen-syms xen-syms.map efi.lds xen.lds mkelf32 mkreloc
> I don't really like to list the files here, since it's very easy for
> them to get out of sync. The alternative I have is also not very nice
> however, since it relies on .gitignore:
> EXCLUDE_FILES:=$(patsubst xen/%,%,$(filter xen/%,$(shell cat $(XEN_ROOT)/.gitignore)))

The correct way to fix this is to rip the current build system to
shreds, start again, and get it to support out-of-tree builds.

This linkfarm logic exists only to work around a hole which we couldn't
fix at the time.

As Andrew observes, the linkfarm code is a temporary solution until Xen supports out of tree builds.

The proposed patch is localized and easy to understand.

If the list of files is not maintained, it will break in obvious ways (either an unnecessary shim rebuild, or a non-rebuild when it should but only in a developer environment) and it will serve as a reminder to fix support for out of tree builds.

So, I'd like to request inclusion of the original patch proposed.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.