Re: [Xen-devel] [PATCH v6] automation: introduce a script for build test

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On Wed, Jul 25, 2018 at 10:24:24AM +0100, Wei Liu wrote:
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
> This is a script I wrote previously for build test.
> 
> Given it basically runs a set of commands on every commit, maybe it should
> be named for-each-commit.sh ?

So if we do that can we make it clear that there's a default action
that's going to be run? Mentally I'd expect a script called like that
would require a command that it would execute but you do have a default.

> +
> +while read num rev; do
> +    echo "Testing $num $rev"
> +
> +    git checkout $rev
> +    ret=$?
> +    if test $ret -ne 0; then
> +        echo "Failed to checkout $num $rev with $ret"
> +        break
> +    fi
> +
> +    if test $# -eq 0 ; then
> +        git clean -fdx && ./configure && make -j4

maybe some comment in the code like "hey someone reading me this is the
default command"

Overall I think this is a good addition to the tree. If people feel
different than I do about the default command then feel free to commit
with my:

Reviewed-by: Doug Goldstein <cardoe@xxxxxxxxxx>

--
Doug

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel