Re: [Xen-devel] [PATCH v7 08/12] arm: add ALL, QEMU, Rcar3 and MPSoC configs

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 27/07/18 11:30, Andrii Anisov wrote:
> On 27.07.18 01:46, Stefano Stabellini wrote:
> > > On 07.07.18 02:13, Stefano Stabellini wrote:
> > > Shouldn't MPSOC_PLATFORM be dependent on ARM64?
> > Yes, and it is, see "config MPSOC" few lines above.
> Few lines above, only "config MPSOC" is dependent on ARM64. But 
> MPSOC_PLATFORM is selected by "config ALL" at the beginning of the 
> patch. And it will be selected for ARM32 as well.
You don't really need to select the platform in ALL. Instead you could 
do something like:
config ALL_64
        default (ALL && ARM_64)

config ALL_32
        default (ALL && ARM_32)

config MPSOC_PLATFORM
        bool
        default (ALL_64 || MPSOC)

> > > > +    bool
> > > > +
> > > > diff --git a/xen/arch/arm/platforms/Makefile
> > > > b/xen/arch/arm/platforms/Makefile
> > > > index 80e555c..a79bdb9 100644
> > > > --- a/xen/arch/arm/platforms/Makefile
> > > > +++ b/xen/arch/arm/platforms/Makefile
> > > > @@ -8,4 +8,4 @@ obj-$(CONFIG_ARM_64) += seattle.o
> > > >    obj-y += sunxi.o
> > > >    obj-$(CONFIG_ARM_64) += thunderx.o
> > > >    obj-$(CONFIG_ARM_64) += xgene-storm.o
> > > > -obj-$(CONFIG_ARM_64) += xilinx-zynqmp.o
> > > > +obj-$(CONFIG_MPSOC_PLATFORM)  += xilinx-zynqmp.o
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel