[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH 2/4] automation: drop container name from containerize

This was something that existed for some scripting support for a totally
unrelated project and when I copied this script I failed to remove it so
this removes it. Build containers for Xen are best as ephemeral
environments and should just utilizes Docker's default container naming

Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
 automation/build/README.md      | 5 -----
 automation/scripts/containerize | 7 +------
 2 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/automation/build/README.md b/automation/build/README.md
index 987533a..bf11317 100644
--- a/automation/build/README.md
+++ b/automation/build/README.md
@@ -53,11 +53,6 @@ understands.
 - XEN_CONFIG_EXPERT: If this is defined in your shell it will be
   automatically passed through to the container.
-- CONTAINER_NAME: By default the container name is set based on the
-  container itself so that its easy to attach other terminals to your
-  container. This however prevents you from running multiple containers
-  of the same version. Override the name value to cause it to name
-  the container differently on start.
 Building a container
diff --git a/automation/scripts/containerize b/automation/scripts/containerize
index 010ed39..2cb8021 100755
--- a/automation/scripts/containerize
+++ b/automation/scripts/containerize
@@ -64,11 +64,6 @@ if [[ -n ${SSH_AUTH_SOCK} ]]; then
-# if we got the CONTAINER_NAME env variable then use that for our name
-if [[ -n ${CONTAINER_NAME} ]]; then
-    name="--name ${CONTAINER_NAME}"
 # Figure out the base of what we want as our sources
 # by using the top of the git repo
 if [[ -n ${CONTAINER_PATH} ]]; then
@@ -86,7 +81,7 @@ exec docker run \
     -v "${HOME}/.ssh":/root/.ssh:ro \
     ${SSH_AUTH_DIR:+-v "${SSH_AUTH_DIR}":/tmp/ssh-agent} \
-    ${CONTAINER_ARGS} ${name} \
     -${termint}i --rm -- \
     ${CONTAINER} \
git-series 0.9.1

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.