Re: [Xen-devel] [PATCH v3 13/25] xen/arm: introduce create_domUs

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.08.18 at 01:27, <sstabellini@xxxxxxxxxx> wrote:
> ---
>  xen/arch/arm/domain_build.c | 42 +++++++++++++++++++++++++++++++++++++++---
>  xen/arch/arm/setup.c        |  7 ++++++-
>  xen/include/asm-arm/setup.h |  3 +++
>  xen/include/asm-x86/setup.h |  2 ++

The (trivial) x86 addition
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit I don't think it really belongs here, since you don't use it
outside of ARM code just yet. If I was an ARM maintainer, I'd
have three more comments/questions:

> @@ -2205,6 +2206,43 @@ static int __init __construct_domain(struct domain *d, 
> struct kernel_info *kinfo
>      return 0;
>  }
>  
> +static int __init construct_domU(struct domain *d, struct dt_device_node 
> *node)
> +{
> +    return 0;

As long as unimplemented I think this should return an error.

> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -63,8 +63,11 @@ static unsigned long opt_xenheap_megabytes __initdata;
>  integer_param("xenheap_megabytes", opt_xenheap_megabytes);
>  #endif
>  
> +domid_t __read_mostly max_init_domid = 0;

Pointless initializer.

> @@ -894,7 +897,7 @@ void __init start_xen(unsigned long boot_phys_offset,
>      dom0_cfg.arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE;
>      dom0_cfg.arch.nr_spis = gic_number_lines() - 32;
>  
> -    dom0 = domain_create(0, &dom0_cfg, true);
> +    dom0 = domain_create(max_init_domid, &dom0_cfg, true);

Why?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel