Re: [Xen-devel] [RFC PATCH 09/17] libxl: use \x1b to separate qemu arguments for linux stubdomain

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Mon, Jul 30, 2018 at 11:56 PM, Marek Marczykowski-Górecki
<marmarek@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> This allows using arguments with spaces, like -append.
> Stubdomain side of this require "xenstore-client: Add option for raw
> in-/output" commit.

I had to look up \x1b - it is ascii escape.  Since I was on the
www.asciitable.com, I saw \x1e is "record seperator" which might make
more sense.

Either way, the code is fine.  It would be good to document the
separator and other interface assumptions like the FDs in a
linux-stubdom document.

Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel