Re: [Xen-devel] [PATCH 5/9] x86/hvm: put hvm_local_events_need_delivery into a header file

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.08.18 at 12:00, <wei.liu2@xxxxxxxxxx> wrote:
> --- /dev/null
> +++ b/xen/include/asm-x86/hvm/event.h
> @@ -0,0 +1,14 @@
> +#ifndef ASM_HVM_EVENT_H
> +#define ASM_HVM_EVENT_H
> +
> +#if CONFIG_HVM
> +
> +int hvm_local_events_need_delivery(struct vcpu *v);
> +
> +#else
> +
> +static inline int hvm_local_events_need_delivery(struct vcpu *v) { return 0; 
> }
> +
> +#endif
> +
> +#endif       /* ASM_HVM_EVENT_H */

Are you expecting more stuff to go into this header? If not, I don't
think a separate header is really warranted here.

Did you consider taking the opportunity and switching the function
to have bool return value at the same time? (Seeing whether the
parameter could also be constified is probably more involved a
task, and hence not suitable here.)

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel