Re: [Xen-devel] [PATCH v1 1/4] xen/arm: drivers: scif: Remove unused #define-s

[Julien Grall <julien.grall@xxxxxxx>]

Hi Oleksandr,

On 06/08/18 19:35, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Julien Grall <julien.grall@xxxxxxx>
Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

> ---
>   xen/drivers/char/scif-uart.c    |  4 ----
>   xen/include/asm-arm/scif-uart.h | 11 -----------
>   2 files changed, 15 deletions(-)
>
> diff --git a/xen/drivers/char/scif-uart.c b/xen/drivers/char/scif-uart.c
> index 4a71bac..465fb34 100644
> --- a/xen/drivers/char/scif-uart.c
> +++ b/xen/drivers/char/scif-uart.c
> @@ -29,10 +29,6 @@
>   #include <asm/scif-uart.h>
>   #include <asm/io.h>
>   
> -#define PARITY_NONE    0
> -#define PARITY_EVEN    1
> -#define PARITY_ODD     2
> -
>   #define scif_readb(uart, off)          readb((uart)->regs + (off))
>   #define scif_writeb(uart, off, val)    writeb((val), (uart)->regs + (off))
>   
> diff --git a/xen/include/asm-arm/scif-uart.h b/xen/include/asm-arm/scif-uart.h
> index d030b26..8137850 100644
> --- a/xen/include/asm-arm/scif-uart.h
> +++ b/xen/include/asm-arm/scif-uart.h
> @@ -47,17 +47,6 @@
>   #define SCSCR_CKE1    (1 << 1)    /* Clock Enable 1 */
>   #define SCSCR_CKE0    (1 << 0)    /* Clock Enable 0 */
>   
> -#define SCSCR_CKE00    (0)
> -#define SCSCR_CKE01    (SCSCR_CKE0)
> -#define SCSCR_CKE10    (SCSCR_CKE1)
> -#define SCSCR_CKE11    (SCSCR_CKE1 | SCSCR_CKE0)
> -
> -/* Serial Mode Register (SCSMR) */
> -#define SCSMR_CHR     (1 << 6)    /* 7-bit Character Length */
> -#define SCSMR_PE      (1 << 5)    /* Parity Enable */
> -#define SCSMR_ODD     (1 << 4)    /* Odd Parity */
> -#define SCSMR_STOP    (1 << 3)    /* Stop Bit Length */
> -
>   /* Serial Status Register (SCFSR) */
>   #define SCFSR_ER      (1 << 7)    /* Receive Error */
>   #define SCFSR_TEND    (1 << 6)    /* Transmission End */
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel