Re: [Xen-devel] [PATCH v1 2/4] xen/arm: drivers: scif: Add support for SCIFA compatible UARTs

[Julien Grall <julien.grall@xxxxxxx>]

Hi Oleksandr,

On 07/08/18 16:01, Oleksandr Tyshchenko wrote:
> On Tue, Aug 7, 2018 at 4:43 PM, Julien Grall <julien.grall@xxxxxxx> wrote:
> > On 06/08/18 19:35, Oleksandr Tyshchenko wrote:
> > I would prefer if you introduce a local variable for the params. This would
> > avoid to write uart->params everywhere.
> Agree. Do you want me to use this local variable only in interrupt
> handler or everywhere in a file where uart->params is used?
At least in all functions where uart->params is used more than once.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel