[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v1 4/4] xen/arm: Reuse R-Car Gen2 platform code for Stout board
Hi, Julien On Tue, Aug 7, 2018 at 6:18 PM, Julien Grall <julien.grall@xxxxxxx> wrote: > Hi, > > On 06/08/18 19:35, Oleksandr Tyshchenko wrote: >> >> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx> >> >> Renesas "Stout" development board (with different expansion boards) >> is also based on R-Car Gen2 SoC. So extend compat array with >> board's compatible strings. >> >> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx> >> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx> >> CC: Julien Grall <julien.grall@xxxxxxx> >> --- >> xen/arch/arm/platforms/rcar2.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/xen/arch/arm/platforms/rcar2.c >> b/xen/arch/arm/platforms/rcar2.c >> index df0ac84..ee2ded0 100644 >> --- a/xen/arch/arm/platforms/rcar2.c >> +++ b/xen/arch/arm/platforms/rcar2.c >> @@ -49,6 +49,10 @@ static int __init rcar2_smp_init(void) >> static const char *const rcar2_dt_compat[] __initconst = >> { >> "renesas,lager", >> + "renesas,r8a7790stout", >> + "renesas,r8a7790stout-view", >> + "renesas,r8a7790stout-had", >> + "renesas,r8a7790stout-full", > > > I am quite reluctant to add compatible that are not present in upstream > Linux. Looking at the DT upstreamed in Linux, the compatible for r8a7790 SoC > seem to be "renesas,r8a7790". Wouldn't it be sufficient to cover all the > boards? But ... This compatible came from official BSP for this board... https://elinux.org/R-Car/Boards/Yocto#Running I have just checked "renesas,r8a7790" and you was right, it covers these modifications. So, I will change. Moreover, we can just have only single compatible, which will cover (I hope) all boards based on R-Car H2 SoC, including Lager board (compatible = "renesas,lager", "renesas,r8a7790") static const char *const rcar2_dt_compat[] __initconst = { - "renesas,lager", + "renesas,r8a7790", NULL }; What do you think? > > ... don't you have PSCI support on those platforms? AFAIK, no. This code is definitely needed for Stout board as well, since the SoC is the same (R-Car Gen2). > > Cheers, > > -- > Julien Grall -- Regards, Oleksandr Tyshchenko _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |