Re: [Xen-devel] [RFC PATCH 2/2] xen/arm: Add MESON UART driver for Amlogic S905 SoC

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.08.18 at 19:07, <amittomer25@xxxxxxxxx> wrote:
> This patch adds driver for UART controller present on Amlogic S905 SoC.
> https://dn.odroid.com/S905/DataSheet/S905_Public_Datasheet_V1.1.4.pdf 
> 
> Signed-off-by: Amit Singh Tomar <amittomer25@xxxxxxxxx>
> ---
>  xen/drivers/char/Kconfig      |   8 ++
>  xen/drivers/char/Makefile     |   1 +
>  xen/drivers/char/meson-uart.c | 290 
> ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 299 insertions(+)
>  create mode 100644 xen/drivers/char/meson-uart.c

The driver being ARM-specific, you will want to update
./MAINTAINERS to also list this new file as ARM-specific.

> --- a/xen/drivers/char/Kconfig
> +++ b/xen/drivers/char/Kconfig
> @@ -20,6 +20,14 @@ config HAS_MVEBU
>         This selects the Marvell MVEBU UART. If you have a ARMADA 3700
>         based board, say Y.
>  
> +config HAS_MESON
> +    bool
> +    default y
> +    depends on ARM_64
> +    help
> +      This selects the Marvell MESON UART. If you have a Amlogic S905
> +      based board, say Y.
> +
>  config HAS_PL011
>       bool
>       default y

Please fix indentation to match that of surrounding code. Also
please use "def_bool y" rather than its longer two line equivalent.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel