[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 1/4] iommu: introduce dom0-iommu option



>>> On 09.08.18 at 12:51, <roger.pau@xxxxxxxxxx> wrote:
> On Thu, Aug 09, 2018 at 04:29:51AM -0600, Jan Beulich wrote:
>> >>> On 09.08.18 at 12:01, <roger.pau@xxxxxxxxxx> wrote:
>> > In fact I think this would be clearer if something like:
>> > 
>> > enum {
>> >     NONE,
>> >     RELAXED,
>> >     STRICT,
>> > } iommu_hwdom = RELAXED;
>> > 
>> > Was used instead of iommu_dom0_passthrough and iommu_dom0_strict.
>> 
>> Fine with me.
> 
> Switching to a single enum also means that the last dom0-iommu = [
> none | strict | relaxed ] will be the one enforced, so I could keep
> them as-is, and add:
> 
> "Note that all the above options are mutually exclusive and the last
> one found on the command line will be the one to take effect."

Right. I don't think the second half of the sentence is needed -
that's what happens for most other options as well.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.