Re: [Xen-devel] [PATCH v16 09/13] x86/hvm: Introduce lapic_save_regs_one func

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.08.18 at 11:20, <aisaila@xxxxxxxxxxxxxxx> wrote:
> This is used to save data from a single instance.
> 
> Signed-off-by: Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit I'm a little puzzled why ...

> --- a/xen/arch/x86/hvm/vlapic.c
> +++ b/xen/arch/x86/hvm/vlapic.c
> @@ -1458,26 +1458,33 @@ static int lapic_save_hidden(struct domain *d, 
> hvm_domain_context_t *h)
>      return err;
>  }
>  
> +static int lapic_save_regs_one(struct vcpu *v, hvm_domain_context_t *h)
> +{
> +    if ( !has_vlapic(v->domain) )
> +        return 0;
> +
> +    if ( hvm_funcs.sync_pir_to_irr )
> +        hvm_funcs.sync_pir_to_irr(v);
> +
> +    return hvm_save_entry(LAPIC_REGS, v->vcpu_id, h, vcpu_vlapic(v)->regs);
> +}
> +
>  static int lapic_save_regs(struct domain *d, hvm_domain_context_t *h)
>  {
>      struct vcpu *v;
> -    struct vlapic *s;
> -    int rc = 0;
> +    int err = 0;
>  
>      if ( !has_vlapic(d) )
>          return 0;

... you leave this here when in patch 8 you've dropped the
equivalent there. But the function as a whole will go away anyway.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel