Re: [Xen-devel] [PATCH] x86/mmcfg: Remove redundant code in pci_mmcfg_reject_broken()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.08.18 at 07:10, <zhenzhong.duan@xxxxxxxxxx> wrote:
> No functional change.
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Albeit I would have wished you would have taken the opportunity
to, at the very least, also move cfg's declaration into the for()
scope. There's obvious further trivial cleanup potential in the
function.

Jan

> --- a/xen/arch/x86/x86_64/mmconfig-shared.c
> +++ b/xen/arch/x86/x86_64/mmconfig-shared.c
> @@ -371,8 +371,6 @@ static bool_t __init pci_mmcfg_reject_broken(void)
>          (pci_mmcfg_config[0].address == 0))
>          return 0;
>  
> -    cfg = &pci_mmcfg_config[0];
> -
>      for (i = 0; i < pci_mmcfg_config_num; i++) {
>          u64 addr, size;
>  
> -- 
> 1.7.3





_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel