Re: [Xen-devel] [PATCH 5/6] x86/shadow: Clean up the MMIO fastpath helpers

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Wed, Aug 15, 2018 at 07:34:36PM +0100, Andrew Cooper wrote:
> Use bool when appropraite, remove extranious brackets and fix up comment
> style.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Just one nit...

> -static inline u32 sh_l1e_mmio_get_flags(shadow_l1e_t sl1e)
> +static inline uint32_t sh_l1e_mmio_get_flags(shadow_l1e_t sl1e)

Is there any reason to use uint32_t instead of unsigned int?

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel