Re: [Xen-devel] [PATCH] x86/mmcfg/drhd: Move acpi_mmcfg_init() before calling acpi_parse_dmar()

[Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>]

在 2018/8/16 18:42, Jan Beulich 写道:
> > > > On 16.08.18 at 11:30, <zhenzhong.duan@xxxxxxxxxx> wrote:
> > On 2018/8/16 17:13, Zhenzhong Duan wrote:
> > > > > --- a/xen/arch/x86/setup.c
> > > > > +++ b/xen/arch/x86/setup.c
> > > > > @@ -1493,6 +1493,10 @@ void __init noreturn __start_xen(unsigned long
> > > > > mbi_p)
> > > > >        generic_apic_probe();
> > > > > +    pt_pci_init();
> > > > > +
> > > > > +    acpi_mmcfg_init();
> > > > > +
> > > > >        acpi_boot_init();
> > > > With the dependency being _in_ acpi_boot_init(), the invocation of
> > > > acpi_mmcfg_init() should now be moved there.
> > > Yes, I feel better to move pt_pci_init() and acpi_mmcfg_init() in
> > > acpi_boot_init() before acpi_mmcfg_init(). Any more comments?
> > I see acpi_boot_init() is empty func when CONFIG_ACPI_BOOT isn't set. Do
> > we support disabling this config option? If yes, I think above change
> > will break non-acpi case.
> I'm sorry, but I'm lost: grep produces no single hit on my tree
> when looking for ACPI_BOOT. Are you looking at some older tree?
> Even when considering ACPI - that Kconfig option exists only for
> ARM's purposes right now. If you were to make it user selectable,
> I think you'd first have to fix a number of build issues in case it
> got turned off.
Sorry, I wrongly looked into oracle internal branch.
In upstream, it's CONFIG_ACPI. It looks not an issue as you said 
CONFIG_ACPI is only for ARM.
Thanks
Zhenzhong

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel