[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] rangeset: make inquiry functions tolerate NULL inputs



On Fri, Aug 17, 2018 at 03:20:11AM -0600, Jan Beulich wrote:
> Rather than special casing the ->iomem_caps check in x86's
> get_page_from_l1e() for the dom_xen case, let's be more tolerant in
> general, along the lines of rangeset_is_empty(): A never allocated
> rangeset can't possibly contain or overlap any range.
> 
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

LGTM:

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

As said in the commit message, this is done to avoid an extra check in
get_page_from_l1e I assume, so should the extra check also be dropped
here?

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.