Re: [Xen-devel] [PATCH 13/34] x86/pt: split out HVM functions from vtd.c

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.08.18 at 17:12, <wei.liu2@xxxxxxxxxx> wrote:
> --- /dev/null
> +++ b/xen/drivers/passthrough/vtd/x86/hvm.c
> @@ -0,0 +1,77 @@
> +/*
> + * Copyright (c) 2008, Intel Corporation.
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License along 
> with
> + * this program; If not, see <http://www.gnu.org/licenses/>.
> + *
> + * Copyright (C) Allen Kay <allen.m.kay@xxxxxxxxx>
> + * Copyright (C) Weidong Han <weidong.han@xxxxxxxxx>
> + */
> +
> +#include <xen/sched.h>
> +#include <xen/softirq.h>
> +#include <xen/domain_page.h>
> +#include <asm/paging.h>
> +#include <xen/iommu.h>
> +#include <xen/irq.h>
> +#include <xen/numa.h>
> +#include <asm/fixmap.h>
> +#include <asm/setup.h>
> +#include "../iommu.h"
> +#include "../dmar.h"
> +#include "../vtd.h"
> +#include "../extern.h"

This is a whole lot of includes for the poor two functions you move:
Are they really all needed? And in any event may I remind you of
our general attempt to sort includes at least in new sources?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel