Re: [Xen-devel] [PATCH 31/34] xen: refuse to create HVM guests when !CONFIG_HVM

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Aug 20, 2018 at 01:59:57PM +0100, Andrew Cooper wrote:
> On 17/08/2018 16:12, Wei Liu wrote:
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> >  xen/common/domain.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/xen/common/domain.c b/xen/common/domain.c
> > index 171d25e..a22df12 100644
> > --- a/xen/common/domain.c
> > +++ b/xen/common/domain.c
> > @@ -318,8 +318,14 @@ struct domain *domain_create(domid_t domid,
> >      if ( !is_idle_domain(d) )
> >      {
> >          if ( config->flags & XEN_DOMCTL_CDF_hvm_guest )
> 
> As discovered during my domain creation rewrite work, libxl on ARM
> doesn't set hvm/hap.
> 
> IMO, they should, and libxl should be fixed.
> 

ISTR they wanted guest type to be PV in libxl.

Wei.

> ~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel