Re: [Xen-devel] [PATCH 26/34] x86/mm/shadow: split out HVM only code

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.08.18 at 17:12, <wei.liu2@xxxxxxxxxx> wrote:
> --- /dev/null
> +++ b/xen/arch/x86/mm/shadow/hvm.c
> @@ -0,0 +1,590 @@
> +
> +/******************************************************************************
> + * arch/x86/mm/shadow/hvm.c
> + *
> + * Shadow code that does not need to be multiply compiled and is HVM only.
> + * Parts of this code are Copyright (c) 2006 by XenSource Inc.
> + * Parts of this code are Copyright (c) 2006 by Michael A Fetterman
> + * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include <xen/types.h>
> +#include <xen/mm.h>
> +#include <xen/trace.h>
> +#include <xen/sched.h>
> +#include <xen/perfc.h>
> +#include <xen/irq.h>
> +#include <xen/domain_page.h>
> +#include <xen/guest_access.h>
> +#include <xen/keyhandler.h>

At the example of this specific include I once again wonder whether
you've simply copied the list of includes from the original file.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel