Re: [Xen-devel] [PATCH v3 2/2] x86/mmcfg/drhd: Move acpi_mmcfg_init() call before calling acpi_parse_dmar()

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Wed, Aug 22, 2018 at 04:39:05PM +0800, Zhenzhong Duan wrote:
> 在 2018/8/22 15:36, Roger Pau Monné 写道:
> > On Tue, Aug 21, 2018 at 09:53:08PM -0700, Zhenzhong Duan wrote:
> > > pci_conf_read8() needs pci mmcfg mapping to work on multiple pci
> > > segments system such as HPE Superdome-Flex.
> > > 
> > > Move acpi_mmcfg_init() call in acpi_boot_init() before calling
> > > acpi_parse_dmar() so that when pci_conf_read8() is called in
> > > acpi_parse_dev_scope(), we already have the mapping set up.
> > > 
> > > mmio_ro_ranges initialization is also moved ahead as it's the only
> > > dependency of pci_mmcfg_arch_enable() need to be moved. Also
> > > checked codes between the old and new call sites to ensure we
> > > don't break anything.
> > > 
> > > Furthermore MMCFG will continue to not work this early (or
> > > more precisely not at all until Dom0 boot has progressed far
> > > enough) if the range(s) isn't/aren't marked reserved in E820.
> > > 
> > > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>
> > > Tested-by: Gopalasetty, Manoj <manoj.gopalasetty@xxxxxxx>
> > 
> > LGTM:
> > 
> > Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Thanks for reviewing.
> > 
> > I'm however failing to find patch 1/2 in this series. Could you please
> > make sure threading is setup correctly?
> Hmm, how to make that happen, do you mean sending the two patches in a
> bunch?
> patch 1/2 is '[PATCH v2 1/2] x86/mmcfg: Rename pt_pci_init() and call it in
> acpi_mmcfg_init()"
> 
> It's acked in v2, so there is no v3 for patch 1/2.

Oh, I see. So you have two choices here: either send patch 1/2 with
the Ack together with patch 2/2, or just drop the 2/2 prefix and send
the patch alone. But sending v3 2/2 without v3 1/2 makes people think
there's a v3 1/2 lost somewhere IMO.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel