Re: [Xen-devel] [RFC PATCH 1/2] xen/arm: Add Amlogic S905 SoC early printk support

[Julien Grall <julien.grall@xxxxxxx>]

On 20/08/18 10:16, Amit Tomer wrote:
> Hello,
Hi Amit,

> > I would prefer if no new alias are added. The same could be achieved with
> > CONFIG_EARLY_PRINTK=meson,0xc81004c0.
> >
> > This could be documented on the wiki.
> Ok.
>
> > I would prefer if we stick with the spec name. So UART_TX_REG should be
> > renamed UART_WFIFO_REG.
> Yeah right, got your point.
> > Also, it might be worth considering to prefix them with AML_ so it is easy
> > to find them on lookup.
> Initially used AML_ as prefix but then I just wanted to be consistent it with
> other uart drivers in XEN.
I think I would prefer to be prefixed with AML_. The non-prefixed 
version is not that convenient for lookup and adding an extra one is not 
going to make better.
> > Looking at the earlyconsole implementation in Linux, it seems that TX needs
> > to be enabled first (see meson_uart_enable_tx_engine).
> >
> > Is it now done in the firmware?
> Yes, this has been done in u-boot.
> shouldn't we trust it?
I am trying to understand why Linux is doing it. Do you expect all 
U-Boot version to do it?
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel