Re: [Xen-devel] [PATCH 12/34] x86/pt: only call some functions for HVM guests

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Aug 20, 2018 at 06:48:58AM -0600, Jan Beulich wrote:
> >>> On 17.08.18 at 17:12, <wei.liu2@xxxxxxxxxx> wrote:
> 
> According to your earlier patch, has_vlapic() implies is_hvm_domain(),
> so if anything is to be moved to the caller, then has_vlapic() (and
> is_hvm_domain() would then to be dropped altogether). However,
> this is again a case where I'm not sure whether adding / extending
> if()-s around calls is indeed preferable over adding static inline stubs.
> Perhaps for the specific one here either variant is about as much (or
> as little) code churn, but for the PI hooks functions I think the stub
> approach might be slightly better.

OK. I will put together some stubs.

Wei.

> 
> Jan
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel