Re: [Xen-devel] [PATCH v1 5/6] libxl: create DTS node for OP-TEE if it is enabled

[Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>]

Hi,

On 23.08.18 17:11, Julien Grall wrote:
> Hi,
>
> On 08/23/2018 03:03 PM, Volodymyr Babchuk wrote:
> > Hi,
> >
> > On 22.08.18 20:32, Julien Grall wrote:
> > > Hi,
> > >
> > > On 22/08/18 15:11, Volodymyr Babchuk wrote:
> > > > Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> > > I am a bit confused. The DT is only here to tell the guest OP-TEE is 
> > > present. But I don't see anything to tell the hypervisor the guest 
> > > will use OP-TEE.
> > Yes, this is what I wanted to discuss. I had a felling that it is not 
> > quite right. I think your idea with DOMCTL is better. I'll rework this 
> > part in the  following way:
> > if there is "optee=1" in a config file, then libxl will create DT 
> > entry and ask hypervisor to enable access to TEE for this domain.
> You probably also want to make the variable TEE agnostic by renaming to 
> "tee".
> In the future, the toolstack would need to know which TEE is in used in 
> the hypervisor. For now, it is fine to assume that it is OP-TEE.
Yes, sounds good. Will do in this way.
Thank you for review and suggestion.

--
Volodymyr Babchuk

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel