Re: [Xen-devel] [PATCH v3 1/6] xen/arm: introduce platform_smc

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 08/11/2018 01:01 AM, Stefano Stabellini wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxxx>
>
> From: Edgar E. Iglesias <edgar.iglesias@xxxxxxxxxx>
I am not sure why there is 2 From here? This seems to apply whole the 
whole series.
> Introduce platform_smc as a way to handle firmware calls that Xen does
> not know about in a platform specific way. This is particularly useful
> for implementing the SiP (SoC implementation specific) service calls.
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xxxxxxxxxx>
> Signed-off-by: Stefano Stabellini <stefanos@xxxxxxxxxx>
> ---
>   xen/arch/arm/platform.c        | 8 ++++++++
>   xen/arch/arm/vsmc.c            | 4 ++++
>   xen/include/asm-arm/platform.h | 3 +++
>   3 files changed, 15 insertions(+)
>
> diff --git a/xen/arch/arm/platform.c b/xen/arch/arm/platform.c
> index 3f2989e..9e19023 100644
> --- a/xen/arch/arm/platform.c
> +++ b/xen/arch/arm/platform.c
> @@ -127,6 +127,14 @@ void platform_poweroff(void)
>           platform->poweroff();
>   }
>   
> +bool platform_smc(struct cpu_user_regs *regs)
> +{
> +    if ( platform && platform->smc )
You might want to add a likely here because most likely a guest is using 
SIP when it is present on the platform.
The rest looks good to me.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel