Re: [Xen-devel] [PATCH v1 1/6] arm: add SMC wrapper that is compatible with SMCCC

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.08.18 at 16:11, <volodymyr_babchuk@xxxxxxxx> wrote:
> Existing SMC wrapper call_smc() allows only 4 parameters and
> returns only one value. This is enough for existing
> use in PSCI code, but TEE mediator will need a call that is
> fully compatible with ARM SMCCC.
> This patch adds this call for both arm32 and arm64.
> 
> There was similar patch by Edgar E. Iglesias ([1]), but looks
> like it is abandoned.
> 
> [1] 
> https://lists.xenproject.org/archives/html/xen-devel/2017-02/msg00636.html 
> 
> CC: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxxx>
> 
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> ---
> 
> changes from "RFC":
>   - response now stored in structure instead of array
>   - added comments for arm32 assembly code
>   - added offset (instead of magic values) for arm32 asm code
> 
>  xen/arch/arm/arm32/Makefile      |  1 +
>  xen/arch/arm/arm32/smc.S         | 39 +++++++++++++++++++++++++++++++++++++++
>  xen/arch/arm/arm64/Makefile      |  1 +
>  xen/arch/arm/arm64/asm-offsets.c |  4 ++++
>  xen/arch/arm/arm64/smc.S         | 30 ++++++++++++++++++++++++++++++
>  xen/include/asm-arm/processor.h  | 11 +++++++++++
>  6 files changed, 86 insertions(+)
>  create mode 100644 xen/arch/arm/arm32/smc.S
>  create mode 100644 xen/arch/arm/arm64/smc.S

With this diffstat, why did I end up on the _To_ list of this patch?
I shouldn't even have been on the Cc list (and I'm going to blindly
delete all other patches of this series where you've also
apparently put me on the To list). Please remember that patches
are supposed to be sent _To_ the list, with maintainers, reviewers
(and perhaps others) Cc-ed. Together with people replying to
mails often not adjusting To/Cc lists accordingly, I've now ended
up with well over 30 mails in my primary mail folder which
presumably I have no business with at all. 

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel