Re: [Xen-devel] [PATCH v2 20/23] xen: connect guest creation with CONFIG_{HVM, PV}

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Aug 28, 2018 at 12:07:24PM +0100, Julien Grall wrote:
> Hi Wei,
> 
> On 26/08/18 13:19, Wei Liu wrote:
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> This patch is going to break Arm until we switched to PVH in the toolstack.
> 
> Cheers,
> 
> > ---
> >   xen/common/domain.c | 14 ++++++++++++++
> >   1 file changed, 14 insertions(+)
> > 
> > diff --git a/xen/common/domain.c b/xen/common/domain.c
> > index 171d25e..73b5485 100644
> > --- a/xen/common/domain.c
> > +++ b/xen/common/domain.c
> > @@ -318,9 +318,23 @@ struct domain *domain_create(domid_t domid,
> >       if ( !is_idle_domain(d) )
> >       {
> >           if ( config->flags & XEN_DOMCTL_CDF_hvm_guest )
> > +        {
> > +#ifdef CONFIG_HVM
> >               d->guest_type = guest_type_hvm;
> > +#else
> > +            err = -EINVAL;
> > +            goto fail;
> > +#endif
> > +        }
> >           else
> > +        {
> > +#ifdef CONFIG_PV

Oh, yes, this should have been

/* Currently toolstack treats ARM guests as PV, bodge it for now until
 * ARM switches to PVH.
 */

#if defined(CONFIG_PV) || defined(CONFIG_ARM)

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel