Re: [Xen-devel] [PATCH] x86/mm: Drop preemptible signal through {get, put}_page_type*()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.08.18 at 17:35, <andrew.cooper3@xxxxxxxxxx> wrote:
> @@ -627,10 +626,10 @@ static int get_page_and_type_from_mfn(
>           unlikely(!get_page_from_mfn(mfn, d)) )
>          return -EINVAL;
>  
> -    rc = _get_page_type(page, type, preemptible);
> +    rc = _get_page_type(page, type);
>  
>      if ( unlikely(rc) && partial >= 0 &&
> -         (!preemptible || page != current->arch.old_guest_table) )
> +         page != current->arch.old_guest_table )
>          put_page(page);

If preemptibility is now tied to the type, how can this part of the
condition go away altogether here? At least I didn't understand
the description to mean everything is meant to become
preemptible.

Same elsewhere. Please clarify.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel