Re: [Xen-devel] [PATCH] x86/mm: Drop {HAP,SHADOW}_ERROR() wrappers

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Aug 28, 2018 at 07:11:54PM +0100, Andrew Cooper wrote:
> Unlike the PRINTK/DEBUG wrappers, these go straight out to the console, rather
> than ending up in the debugtrace buffer.
> 
> A number of these users are followed by domain_crash(), and future changes
> will want to combine the printk() into the domain_crash() call.  Expand these
> wrappers in place, using XENLOG_ERR before a BUG(), and XENLOG_G_ERR before a
> domain_crash().
> 
> Perfom some %pv/PRI_mfn/etc cleanup while modifying the invocations, and
> explicitly drop some calls which are unnecessary (bad shadow op, and the empty
> stubs for incorrect sh_map_and_validate_gl?e() calls).

Do you not want to retain the respective prefixes (hap error / sh
error)? I think they are useful to a degree. But then you can already
tell which subsystem goes wrong by grepping the error message in code.

In any case, code-wise:

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel