Re: [Xen-devel] [PATCH] x86/alt: Fix build when CONFIG_LIVEPATCH is disabled

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.08.18 at 12:57, <andrew.cooper3@xxxxxxxxxx> wrote:
> c/s b28cd21c3628 "x86/build: Use new .nops directive when available"
> introduced a __read_mostly boolean which is included if the toolchain supports
> the .nops directive.
> 
> When CONFIG_LIVEPATCH is compiled out, alternative.o is expected to be a fully
> init module, and toolchain_nops_are_ideal trips the build system check:
> 
>   Error: size of alternative.o:.data.read_mostly is 0x01
>   /local/xen.git/xen/Rules.mk:206: recipe for target 'alternative.init.o' 
> failed
>   make[3]: *** [alternative.init.o] Error 12
> 
> Introduce init_or_livepatch_read_mostly and switch the annotation for
> toolchain_nops_are_ideal.
> 
> Reported-by: Olaf Hering <olaf@xxxxxxxxx>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

(I've just run into this as well.)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel