[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 12/12] xen/domain: Allocate d->vcpu[] in domain_create()


  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 29 Aug 2018 13:29:50 +0100
  • Autocrypt: addr=andrew.cooper3@xxxxxxxxxx; prefer-encrypt=mutual; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA==
  • Cc: Julien Grall <julien.grall@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxx>
  • Delivery-date: Wed, 29 Aug 2018 12:30:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Openpgp: preference=signencrypt

On 29/08/18 13:10, Jan Beulich wrote:
>>>> On 29.08.18 at 12:36, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 15/08/18 16:18, Jan Beulich wrote:
>>>>>> --- a/xen/common/domctl.c
>>>>>> +++ b/xen/common/domctl.c
>>>>>> @@ -554,16 +554,9 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) 
>> u_domctl)
>>>>>>  
>>>>>>          ret = -EINVAL;
>>>>>>          if ( (d == current->domain) || /* no domain_pause() */
>>>>>> -             (max > domain_max_vcpus(d)) )
>>>>>> +             (max != d->max_vcpus) )   /* max_vcpus set up in 
>>>>>> createdomain 
>> */
>>>>>>              break;
>>>>>>  
>>>>>> -        /* Until Xenoprof can dynamically grow its vcpu-s array... */
>>>>>> -        if ( d->xenoprof )
>>>>>> -        {
>>>>>> -            ret = -EAGAIN;
>>>>>> -            break;
>>>>>> -        }
>>>>>> -
>>>>>>          /* Needed, for example, to ensure writable p.t. state is 
>>>>>> synced. */
>>>>>>          domain_pause(d);
>>>>>>  
>>>>>> @@ -581,38 +574,8 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) 
>> u_domctl)
>>>>>>              }
>>>>>>          }
>>>>>>  
>>>>>> -        /* We cannot reduce maximum VCPUs. */
>>>>>> -        ret = -EINVAL;
>>>>>> -        if ( (max < d->max_vcpus) && (d->vcpu[max] != NULL) 
>>>>>> )xc_domain_max_vcpus
>>>>>> -            goto maxvcpu_out;
>>>>>> -
>>>>>> -        /*
>>>>>> -         * For now don't allow increasing the vcpu count from a non-zero
>>>>>> -         * value: This code and all readers of d->vcpu would otherwise 
>>>>>> need
>>>>>> -         * to be converted to use RCU, but at present there's no tools 
>>>>>> side
>>>>>> -         * code path that would issue such a request.
>>>>>> -         */
>>>>>> -        ret = -EBUSY;
>>>>>> -        if ( (d->max_vcpus > 0) && (max > d->max_vcpus) )
>>>>>> -            goto maxvcpu_out;
>>>>>> -
>>>>>>          ret = -ENOMEM;
>>>>>>          online = cpupool_domain_cpumask(d);
>>>>>> -        if ( max > d->max_vcpus )
>>>>>> -        {
>>>>>> -            struct vcpu **vcpus;
>>>>>> -
>>>>>> -            BUG_ON(d->vcpu != NULL);
>>>>>> -            BUG_ON(d->max_vcpus != 0);
>>>>>> -
>>>>>> -            if ( (vcpus = xzalloc_array(struct vcpu *, max)) == NULL )
>>>>>> -                goto maxvcpu_out;
>>>>>> -
>>>>>> -            /* Install vcpu array /then/ update max_vcpus. */
>>>>>> -            d->vcpu = vcpus;
>>>>>> -            smp_wmb();
>>>>>> -            d->max_vcpus = max;
>>>>>> -        }
>>>>>>  
>>>>>>          for ( i = 0; i < max; i++ )
>>>>>>          {
>>>>> With all of this dropped, I think the domctl should be renamed. By
>>>>> dropping its "max" input at the same time, there would then also
>>>>> no longer be a need to check that the value matches what was
>>>>> stored during domain creation.
>>>> I'm still looking to eventually delete the hypercall, but we need to be
>>>> able to clean up all domain/vcpu allocations without calling
>>>> complete_domain_destroy, or rearrange the entry logic so
>>>> complete_domain_destroy() can be reused for a domain which isn't
>>>> currently in the domlist.
>>>>
>>>> Unfortunately, I think this is going to be fairly complicated, I think.
>>> Especially when we expect this to take some time, I think it would
>>> be quite helpful for the domctl to actually say what it does until
>>> then, rather than retaining its current (then misleading) name.
>> Renaming the domctl means renaming xc_domain_max_vcpus(), and the
>> python/ocaml stubs, the latter of which does have external users.
> This is an option, but the libxc and higher layer functions could as well
> be left alone, perhaps with a comment added to the function you name
> explaining why its name doesn't match the domctl it uses.

And what good will that do?  You'll now have inconsistent naming, which
is worse.

Its either all or nothing, and there are several good reasons to not
change everything.  I definitely don't think renaming the infrastructure
is a constructive use of my time, or anyone elses for that matter.

I'm open to the idea of leaving a comment by the implementation of
XEN_DOMCTL_max_vcpus: explaining its change in behaviour, but I think
that the extent of what is reasonable to do here.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.