[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/grant: Mute gcc warning in steal_linear_address()



On Wed, Aug 29, 2018 at 09:06:02PM -0700, Zhenzhong Duan wrote:
> Move reference of ol1e ahead or else we see below warning.
> 
> cc1: warnings being treated as errors
> grant_table.c: In function 'replace_grant_pv_mapping':
> grant_table.c:142: warning: 'ol1e.l1' may be used uninitialized in this 
> function
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

I don't think there is a bug in the code. The compiler isn't smart
enough to figure out ol1e won't be used when okay is false.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.