Re: [Xen-devel] [PATCH v2] x86/pv: Deprecate support for paging out the LDT

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.08.18 at 14:27, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 30/08/18 13:25, Jan Beulich wrote:
>>>>> On 30.08.18 at 11:55, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> --- a/xen/arch/x86/Kconfig
>>> +++ b/xen/arch/x86/Kconfig
>>> @@ -164,3 +164,26 @@ endmenu
>>>  source "common/Kconfig"
>>>  
>>>  source "drivers/Kconfig"
>>> +
>>> +menu "Deprecated Functionality"
>>> +
>>> +config LEGACY_PV_LDT_PAGING
>>> +   def_bool n
>> Can this please simply be "bool" and depend on PV right away
> 
> Sure.  (I believe this patch actually predicates CONFIG_PV entirely).
> 
>> (maybe the name would then also better have PV_ first, but
>> I'll leave that part up to you)? With that
>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Perhaps drop it to just CONFIG_PV_LDT_PAGING ?  The LEGACY part is
> rather redundant.

I was about to suggest that and then didn't, assuming you had put
it there on purpose.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel