Re: [Xen-devel] [PATCH] xen: Improvements to domain_crash()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.08.18 at 15:48, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 31/08/18 09:39, Jan Beulich wrote:
>>>>> On 30.08.18 at 17:31, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> @@ -2686,17 +2678,22 @@ static void *hvm_map_entry(unsigned long va, bool_t 
>>> *writable)
>>>      pfec = PFEC_page_present;
>>>      gfn = paging_gva_to_gfn(current, va, &pfec);
>>>      if ( pfec & (PFEC_page_paged | PFEC_page_shared) )
>>> -        goto fail;
>>> +    {
>>> +        domain_crash(current->domain, "Descriptor table is paged or 
>>> shared\n");
>> Since a page can't be paged and shared at the same time, perhaps better
>> to log just one of the two (whichever is applicable)?
> 
> I could format pfec into the message?

That's also an option, but slightly more difficult to decipher, should it
really happen to be logged.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel