Re: [Xen-devel] [PATCH] hvmloader: fix build with LLVM Linker

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.09.18 at 16:19, <roger.pau@xxxxxxxxxx> wrote:
> On Mon, Aug 27, 2018 at 03:50:39AM -0600, Jan Beulich wrote:
>> >>> On 24.08.18 at 11:58, <roger.pau@xxxxxxxxxx> wrote:
>> > --- /dev/null
>> > +++ b/tools/firmware/hvmloader/hvmloader.lds
>> > @@ -0,0 +1,13 @@
>> > +SECTIONS
>> > +{
>> > +  . = 0x100000;
>> > +  /*
>> > +   * NB: there's no need to use the AT keyword in order to set the LMA, by
>> > +   * default the linker will use VMA = LMA unless specified otherwise.
>> > +   */
>> > +  .text : { *(.text) }
>> > +  .rodata : { *(.rodata) }
>> > +  .data : { *(.data) }
>> > +  .bss : { *(.bss) }
>> > +  _end = .;
>> > +}
>> 
>> Is this really sufficient? Iirc the compiler could create quite a few
>> more variants of the sections named above, like .rodata.str* or
>> .text.cold. Hence at the very least I'd expect .<section> on the
>> right sides above to be accompanied by .<section>.* .
> 
> Right, ATM the compiler I'm using doesn't generate any of those, but
> you are correct that this could be the case.
> 
> Do you have a preference for adding .<section>.* instead of just using
> a single .<section>*?

Yes, I think we shouldn't match more aggressively than we have to.
.text.* etc are well known forms, and while .text1 etc may also be,
I wouldn't want to match more exotic ones like .textual.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel