Re: [Xen-devel] [PATCH 2/2] tools/libxl: Switch Arm guest type to PVH

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Sep 03, 2018 at 12:11:27PM +0100, Julien Grall wrote:
> I don't think so. The top makefile does not pass -DCONFIG_ARM on compiler
> command line. This is only done in sub-directory such as console and
> libacpi.

Indeed. That how console code did it.

> 
> > 
> > There are several CONFIG_ARM* in toolstack code, though not in libxl. In
> > any case, I think the code is fine as-is.
> 
> I am happy to introduce CONFIG_ARM/CONFIG_X86 if you don't mind adding
> -DCONFIG_ARM on the command line.

I'm not too fussed. Keeping your code as-is is fine.

Wei.

> 
> Cheers,
> 
> -- 
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel