Re: [Xen-devel] [PATCH v6 04/14] iommu: don't domain_crash() inside iommu_map/unmap_page()

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 04 September 2018 11:38
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: Julien Grall <julien.grall@xxxxxxx>; Andrew Cooper
> <Andrew.Cooper3@xxxxxxxxxx>; Wei Liu <wei.liu2@xxxxxxxxxx>; George
> Dunlap <George.Dunlap@xxxxxxxxxx>; Ian Jackson <Ian.Jackson@xxxxxxxxxx>;
> Jun Nakajima <jun.nakajima@xxxxxxxxx>; Kevin Tian
> <kevin.tian@xxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; xen-
> devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>; Konrad Rzeszutek Wilk
> <konrad.wilk@xxxxxxxxxx>; Tim (Xen.org) <tim@xxxxxxx>
> Subject: Re: [PATCH v6 04/14] iommu: don't domain_crash() inside
> iommu_map/unmap_page()
> 
> >>> On 23.08.18 at 11:47, <paul.durrant@xxxxxxxxxx> wrote:
> > --- a/xen/common/grant_table.c
> > +++ b/xen/common/grant_table.c
> > @@ -1154,6 +1154,7 @@ map_grant_ref(
> >          }
> >          if ( err )
> >          {
> > +            domu_crash(ld);
> >              double_gt_unlock(lgt, rgt);
> 
> You crash the domain with both locks held here, but ...
> 
> > @@ -1406,7 +1407,10 @@ unmap_common(
> >          double_gt_unlock(lgt, rgt);
> >
> >          if ( err )
> > +        {
> > +            domu_crash(ld);
> >              rc = GNTST_general_error;
> > +        }
> 
> ... outside of the locked region here. I think the latter is fine, and
> hence the former should be changed.

Sure. Will do.

> 
> With that
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 

Thanks,

  Paul

> Jan
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel