[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 01/23] x86: change name of parameter for various invlpg functions





On 09/03/2018 09:46 AM, Wei Liu wrote:
On Sun, Aug 26, 2018 at 01:19:34PM +0100, Wei Liu wrote:
They all incorrectly named a parameter virtual address while it should
have been linear address.

Requested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
Is there more comment on this?

These being rather mechanical changes makes me wonder if I should wait
to collect all necessary ack/review or just go ahead with Jan and
Kevin's.


As I said earlier, I am not convinced this change is necessary since AMD defines virtual and linear addresses as synonyms (see, for example, section 1.1.1. in volume 2).

However, if others think linear is a better term to use, that's fine too.

Acked-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.